Pull Requests and Issues

c1ff

You may know what I'm talking about if you use github. For those who don't…

What is a Pull Request?

Pull requests are used by github.com to help coders suggest code to other coders.

How it works :
1. Make a fork (remix)
2. Code the remix
3. Suggest a pull request to the origional project.

This means big project owners can merge code from others (like huge amounts of overhaul) without hours of coding over the laggy scratch client. (Trust me, it's laggy. Even moving medium sized scripts can cause very low preformance.)

What is an Issue?

Exactly what it sounds like. An issue. A problem. A bug.

This means you can post bugs without them getting mingled and forgotten in the low-to-no conversational comments like “_waffle_ _waffle_ cool” and other comments that were posted in too much of a hurry. Bugs need to be seperated from other comments and handled seperately.

Also like github, could I suggest having comments in Markdown, rather than plain text with images allowed?

Also, pull requests mean you can suggest new textures without posting an entire project to hold your sprites and images.

iwotastic

Pull Requests: Support Note: Except maybe change the name from Pull Request to something a little more suited for people new to programming (like remixes instead of forking).

Issues: Half Support Note: This would be good, except I foresee these used to spam even more (and the reason above).

Markdown: Half Support Note: Maybe they could use BBCode like in the forums.

Last edited by iwotastic (April 6, 2015 22:28:55)

c1ff

Pull Requests: Support Note: Except maybe change the name from Pull Request to something a little more suited for people new to programming (like remixes instead of forking).

True. Maybe Merge Request?

Issues: Half Support Note: This would be good, except I foresee these used to spam even more (and the reason above).

Well, the thing is, an issue is basically BRODCASTING your message so that it can be found. So even with spamming, which can be done with one user, the user can be reported pretty quickly. And you could allow only a certain amount of issues per user per day.

Markdown: Half Support Note: Maybe they could use BBCode like in the forums.

Maybe it could be customizable which one is used, that way people familiar to both could use it.

FalconGunner99

For the first idea, this might be cool, but I also can forsee every nine year old and their grandmother marking their remix as a pull request for attention, even if their code is terrible.

For the second, I think a better idea is just to remix and/or leave a comment on the person's profile.

For the third, I'm indifferent, but at the very least, we need to be able to space out our lines of text for slightly better formatting.

Standard limits would still need to apply obviously. Wouldn't want people doing

this.

c1ff

Grandmothers use scratch? That's rather strange. Maybe they sew virtual clothes.

Comments on profiles would just be irrelevant to the person. When you leave comments, you want them to be on the page relevant to them. If scratch ever becomes un-laggy and people want to make giant projects that are near 100 sprites and 1000 scripts, we want to be able to post bugs where needed.

MegaApuTurkUltra

Pull requests: Support if renamed to something like “Project update requests”

Issues: Support. They should work just like comments (ie, same limits) but more strict.

Markdown: Support. The forum should have markdown too. It's a lot easier to use (especially for newer people) than BBCode IMO

scratchieguy12345678

Support for pull requests and issues! I could see how this could be useful, especially for collaborations!

gosoccerboy5

The collaborations forum could be used for this.
A pull request would just be a remix of the project with some changes and then the original project creator can simply upload that back, which you can already do already.

o97doge

HUGE SUPPORT!
Pull requests could be used for submitting a new fun level to a game.
Issues could be used to actually get bug reports without the spam that is in the comment section.

Edit: Pull requests could also be used for submitting bug fixes.

Last edited by o97doge (Jan. 6, 2024 04:39:51)

o97doge

bbcode mockup

A Scratcher wrote:

Bug fix for your game
this fixes a bug in your game because of the say [Hello!] block not being in the right place.

when green flag clicked
blah blah blah :: custom
blah blah blah :: custom
blah blah blah * (2) :: custom
blah blah blah :: custom
blah blah blah :: custom
blah blah blah [blah] blah blah :: custom
blah blah blah for (10) secs :: custom
blah blah blah :: custom
...
blah blah blah :: custom
blah blah blah :: custom
removed {
	repeat (10) 
		
	end
	say [Hello!]
} :: #FF0000
added {
	repeat (10) 
		say [Hello!]
	end
} :: #008B17
blah blah blah :: custom
blah blah blah :: custom
meow meow meow :: custom
blah blah blah :: custom
woof woof :: custom
blah blah blah :: custom

RethinkingVoxels

Couldn't this lead to private messaging?

ajskateboarder

Perhaps the diffing could be done based on how scratch-git does it? (COMPLETELY NECESSARY DISCLAIMER: I am the main author of scratch-git)

RethinkingVoxels wrote:
Couldn't this lead to private messaging?

… No? This offers a Git/GitHub-like issue and code merging experience for Scratch

o97doge

bump (i think it's been 24 hours)

o97doge

bump

o97doge

bump

o97doge

Bump.

banana439monkey

how beneficial is this?
the idea of scratch is mainly to encourage remixing, although i guess this kind of concept would kill the need for collaboration accounts
but then this would involve a concept similar to git, which causes the project to spiral out of control (referring to spiral development)
i think we need to manage scope here but you're suggesting a pretty complex feature

Banana

MyScratchedAccount

Bump, since I like this suggestion

o97doge

Bump. This is a good way to implement collaboration safely.

Last edited by o97doge (May 4, 2025 22:57:01)

flips_2_1

Bump, this could make collaboration work more nicely.

Discuss Scratch