awesome-llama wrote:

I can guess by looking at the code…
I haven't gone to the length of running it or debugging it, I am only reading it and guessing what the functions are doing with certain data.

One of the places that the effect blocks are implemented is in the sprite fragment shader.
https://github.com/LLK/scratch-render/blob/develop/src/shaders/sprite.frag

Here's the line responsible for changing hue and also setting the RGB colour afterwards. (hsv is a 3D vector here and the x component would be hue, u_color is the value from the colour effect)

hsv.x = mod(hsv.x + u_color, 1.0);
if (hsv.x < 0.0) hsv.x += 1.0;
gl_FragColor.rgb = convertHSV2RGB(hsv);

I assume what's happening is the modulo operator is not able to handle Infinity and so it returns something that ends up affecting the HSV to RGB conversion afterwards in an unexpected way.

Also here's the conversion code:

vec3 convertHue2RGB(float hue)
{
	float r = abs(hue * 6.0 - 3.0) - 1.0;
	float g = 2.0 - abs(hue * 6.0 - 2.0);
	float b = 2.0 - abs(hue * 6.0 - 4.0);
	return clamp(vec3(r, g, b), 0.0, 1.0);
}
vec3 convertHSV2RGB(vec3 hsv)
{
	vec3 rgb = convertHue2RGB(hsv.x);
	float c = hsv.z * hsv.y;
	return rgb * c + hsv.z - c;
}

when green flag clicked
set [color] effect to (1/0)

Comment_master29 wrote:

What is this topic even about?

set [Color v] effect to (join [Infinity] [])

jlnilocalsip wrote:

Do you guys not understand the absolute terror of grayscale in Scratch projects

Blah blah blah

jlnilocalsip wrote:

Do you guys not understand the absolute terror of grayscale in Scratch projects

Grayscale puts you in mind of the past. Film noir hardboiled detectives living rainfully in the lightlamped smoky streets seeing so many plotlines go wrong. Overly narrated newsreels depicting huddled masses and military marches from worlds on the brink of destruction. Boiled-laughter sitcoms with a thousand naive punchlines spilling from the mouths of redheads and honeymooners lost to the ages in the picture of a domestic life which never existed. A zeitgeist long gone which now walks intertwining our perceptions of what was and what should be like an infinite warped knot of time upon time. They are all lost souls now, two-fisted heroes of the past liverspotted and grayhaired, wheeled up to the podium at awards ceremonies and appearing in infomercials for social security. Grayscale gives you the nightmare of history from which we are all trying to wake.

jlnilocalsip wrote:

Do you guys not understand the absolute terror of grayscale in Scratch projects

Grayscale puts you in mind of the past. Film noir hardboiled detectives living rainfully in the lightlamped smoky streets seeing so many plotlines go wrong. Overly narrated newsreels depicting huddled masses and military marches from worlds on the brink of destruction. Boiled-laughter sitcoms with a thousand naive punchlines spilling from the mouths of redheads and honeymooners lost to the ages in the picture of a domestic life which never existed. A zeitgeist long gone which now walks intertwining our perceptions of what was and what should be like an infinite warped knot of time upon time. They are all lost souls now, two-fisted heroes of the past liverspotted and grayhaired, wheeled up to the podium at awards ceremonies and appearing in infomercials for social security. Grayscale gives you the nightmare of history from which we are all trying to wake.