Discuss Scratch

#1Sept. 25, 2020 22:56:13
Wyan100
Scratcher
1000+ posts

The Check mark is broken?

My browser / operating system: Windows NT 10.0, Chrome 85.0.4183.121, No Flash version detected

So you know the little check mark that you press to see your post? (Mine's right there /\ at the moment)

Well recently if I type:

ExampleText wrote:

whenclickedgotoPizza Shopsetvolumeto500%sayWHERE'S THE TACOS?!?!?

then press the Checkmark, on my screen it pops up as:

BrokenText wrote:

<br/><br/><blockquote><p class=“bb-quote-author”>ExampleText wrote:</p><pre class=“blocks”>when green flag clicked<br/>go to <br/>set volume to (500) %<br/>say </pre></blockquote><br/>

Do you know why this is happening? And if I can make it stop?
#2Sept. 25, 2020 23:08:27
mtech22
Scratcher
1000+ posts

The Check mark is broken?

That sounds like the HTML may be appearing instead of the bbcode. Did you recently install any browser extensions, and did you try reloading the page? I don't know much about HTML so thats all I could think of.

Last edited by mtech22 (Sept. 25, 2020 23:08:41)

#3Sept. 25, 2020 23:12:06
Wyan100
Scratcher
1000+ posts

The Check mark is broken?

mtech22 wrote:

That sounds like the HTML may be appearing instead of the bbcode. Did you recently install any browser extensions, and did you try reloading the page? I don't know much about HTML so thats all I could think of.

I haven't installed any Browser Extensions (I think…)

Also if I reload the page it deletes what I was writing so I'm not exactly sure how that would help…

BrokenText wrote:

<blockquote><p class=“bb-quote-author”>mtech22 wrote:</p>That sounds like the HTML may be appearing instead of the bbcode. Did you recently install any browser extensions, and did you try reloading the page? I don't know much about HTML so thats all I could think of.</blockquote><br/>I haven't installed any Browser Extensions <span class=“bb-small”>(I think&#8230; )</span><br/><br/>Also if I reload the page it deletes what I was writing so I'm not exactly sure how that would help&#8230;

Last edited by Wyan100 (Sept. 25, 2020 23:12:41)

#4Sept. 25, 2020 23:14:08
mtech22
Scratcher
1000+ posts

The Check mark is broken?

If i quote someone, this will happen, but if i don't, nothing will. Strange.
Edit: NVM, it shows when I insert BBCODE.

Last edited by mtech22 (Sept. 25, 2020 23:14:42)

#5Sept. 25, 2020 23:23:40
Wyan100
Scratcher
1000+ posts

The Check mark is broken?

mtech22 wrote:

If i quote someone, this will happen, but if i don't, nothing will. Strange.
Edit: NVM, it shows when I insert BBCODE.

I T S S P R E A D I N G.
#6Sept. 26, 2020 04:20:53
gdpr70f61245d597c25631fbb669
Scratcher
100+ posts

The Check mark is broken?

Yep, I can confirm this is happening for me as well. It seems the HTML is being escaped when it should not be.
#7Sept. 26, 2020 05:56:38
kenny2scratch
Scratcher
500+ posts

The Check mark is broken?

Confirmed on Windows NT 10.0, Chrome 85.0.4183.121 while I was editing this post:
#8Sept. 26, 2020 06:06:49
DownsGameClub
Scratcher
1000+ posts

The Check mark is broken?

This appears to be a site wide issue. I'm getting this on my MacBook as well.
My browser / operating system: MacOS Macintosh X 10.15.6, Safari 14.0.

Honestly, it's kinda funny that it's spitting out the HTML instead of what would show up.



#9Sept. 26, 2020 06:06:55
bigpuppy
Scratcher
1000+ posts

The Check mark is broken?

My browser / operating system: MacOS Macintosh X 10.15, Firefox 81.0, Flash 32.0 (release 0)

Can reproduce:
#10Sept. 26, 2020 06:59:44
Maximouse
Scratcher
1000+ posts

The Check mark is broken?

CR
My browser / operating system: Windows NT 10.0, Chrome 85.0.4183.102 Microsoft Edge 85.0.564.51



The Scratch Team was probably trying to fix a bug and accidentally messed up something.
#11Sept. 26, 2020 07:34:24
whiteandblackcat
Scratcher
1000+ posts

The Check mark is broken?

Can also reproduce
My browser / operating system: MacOS Macintosh X 10.15.6, Safari 14.0, No Flash version detected

If it helps, I tried quitting safari and reloading the page and neither helped
I also incidentally restarted my computer today and no change
Although judging by the range of people, browsers and OSs having this problem, it seems to be on scratch's end

Last edited by whiteandblackcat (Sept. 26, 2020 07:34:37)

#12Sept. 26, 2020 07:49:10
Maximouse
Scratcher
1000+ posts

The Check mark is broken?

I think I found the reason: the server incorrectly escapes HTML tags in the preview.


Assuming the forums code hasn't changed much since 2016, they might have removed |safe from templates/djangobb_frum/post_preview.html, line 27, or, less likely, changed the post_preview view itself.

Last edited by Maximouse (Sept. 26, 2020 07:49:36)

#13Sept. 26, 2020 08:25:46
JustTbear
Scratcher
100+ posts

The Check mark is broken?

ok let me look at this
bbcode

yes wrote:

ok let me look at this<br/><span class=“bb-bold”>bbcode</span>

including previous quote wrote:

ok let me look at this<br/><span class=“bb-bold”>bbcode</span><br/><blockquote><p class=“bb-quote-author”>yes wrote:</p>ok let me look at this&lt;br/&gt;&lt;span class=&ldquo;bb-bold&rdquo;&gt;bbcode&lt;/span&gt;<br/></blockquote>
#14Sept. 26, 2020 08:27:53
mybearworld
Scratcher
1000+ posts

The Check mark is broken?

Test Test!!!
Everything works fine?
Ohh forget it. When you put an enter, it gives you “<br>”…
Oh. And <br> is &ldquo;&lt;br&gt;&rdquo;&#8230;
I could go in a loop for agess…
TEEST
<span class=“bb-bold”>TEEST</span>
Okay, that's something weird. Hope a developer sees this!
#15Sept. 26, 2020 09:11:33
Jeffalo
Scratcher
1000+ posts

The Check mark is broken?

i think it might be likely someone found some kind of xss vulnerability, and then the ST took a very interesting approach to sanitizing the HTML…
#16Sept. 26, 2020 09:16:36
Maximouse
Scratcher
1000+ posts

The Check mark is broken?

Jeffalo wrote:

i think it might be likely someone found some kind of xss vulnerability, and then the ST took a very interesting approach to sanitizing the HTML…
Maybe lol
#17Sept. 26, 2020 09:21:46
Jeffalo
Scratcher
1000+ posts

The Check mark is broken?

Maximouse wrote:

Jeffalo wrote:

i think it might be likely someone found some kind of xss vulnerability, and then the ST took a very interesting approach to sanitizing the HTML…
Maybe lol
i don't really have the right to criticize…

my website
#18Sept. 26, 2020 09:37:50
-InsanityPlays-
Scratcher
1000+ posts

The Check mark is broken?

Can reproduce and confirm - this is happening on Chromebook as well.
#19Sept. 26, 2020 10:59:54
Jeffalo
Scratcher
1000+ posts

The Check mark is broken?

Za-Chary wrote:

Agreed. This was expected, from a change that someone made to the inner workings of the website. I've forwarded this on to them.
#20Sept. 26, 2020 12:51:23
lovecodeabc
Scratcher
1000+ posts

The Check mark is broken?

Oh iPad does not work
My browser / operating system: MacOS Macintosh X 10.15.4, Safari 13.1.2, No Flash version detected
Like
National Weather service
It looks like
Oh iPad does not work<br/>My browser / operating system: MacOS Macintosh X 10.15.4, Safari 13.1.2, No Flash version detected<br/>Like<br/><a href="http://weather.gov">National Weather service</a>

Powered by DjangoBB